From 1fd53e0ae4e919b70fd1c4198c273aee673fb53f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 14 Mar 2026 08:18:54 +0000 Subject: [PATCH] fix: address code review - use full timestamp for dedup key, set today's date on cache reset Co-authored-by: qinfendebingshuo <207279273+qinfendebingshuo@users.noreply.github.com> --- .github/workflows/daily-maintenance.yml | 4 ++-- scripts/update-readme-bulletin.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/daily-maintenance.yml b/.github/workflows/daily-maintenance.yml index c8c5ac4b..4272cba3 100644 --- a/.github/workflows/daily-maintenance.yml +++ b/.github/workflows/daily-maintenance.yml @@ -30,13 +30,13 @@ jobs: if [ -f "$CACHE_FILE" ]; then CACHE_DATE=$(jq -r '.date // ""' "$CACHE_FILE" 2>/dev/null || echo "") if [ "$CACHE_DATE" != "$TODAY" ]; then - echo '{"date":"","records":[]}' > "$CACHE_FILE" + echo "{\"date\":\"$TODAY\",\"records\":[]}" > "$CACHE_FILE" echo "✅ 公告栏缓存已清空(旧日期: $CACHE_DATE)" else echo "📌 公告栏缓存日期匹配今天 ($TODAY),无需清空" fi else - echo '{"date":"","records":[]}' > "$CACHE_FILE" + echo "{\"date\":\"$TODAY\",\"records\":[]}" > "$CACHE_FILE" echo "✅ 创建新的公告栏缓存文件" fi diff --git a/scripts/update-readme-bulletin.js b/scripts/update-readme-bulletin.js index 5f6d166e..5dbcdd6d 100644 --- a/scripts/update-readme-bulletin.js +++ b/scripts/update-readme-bulletin.js @@ -194,7 +194,7 @@ function appendToCache(cache, newEntries) { const existingKeys = new Set(cache.records.map(r => r.key)); let added = 0; for (const e of newEntries) { - const key = `${e.actor}|${e.module || '—'}|${formatTimeShort(e.ts)}`; + const key = `${e.actor}|${e.module || '—'}|${e.ts || ''}`; if (!existingKeys.has(key)) { existingKeys.add(key); cache.records.push({